Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix Windows tests, 'call conda activate' #51

Closed
wants to merge 3 commits into from
Closed

fix Windows tests, 'call conda activate' #51

wants to merge 3 commits into from

Conversation

mbargull
Copy link
Member

Checklist

  • Used a fork of the feedstock to propose changes

xref: #49 (comment) (cc: @jakirkham, @kalefranz)

I'm not sure when that temporary directory for which all those Access is denied errors happen comes into play.

But the logs indicate (https://ci.appveyor.com/project/conda-forge/conda-feedstock/build/1.0.130/job/9wf7g6m38thf4o2e#L1261) that

conda-feedstock/recipe/run_test.bat

Line 23 in c999046

conda activate base
is the last command that is run by the tests. That one need to be changed to call.
(I didn't change the build number because I suppose a new build isn't necessary -- unless the tests fail now and indicate a faulty build, of course.)

@conda-forge-linter
Copy link

Hi! This is the friendly automated conda-forge-linting service.

I just wanted to let you know that I linted all conda-recipes in your PR (recipe) and found it was in an excellent condition.

@scopatz
Copy link
Member

scopatz commented May 21, 2018 •
edited
Loading

LGTM - waiting on CI

@mbargull
Copy link
Member Author

Duh... the same for deactivate, too, of course.

@scopatz
Copy link
Member

scopatz commented May 21, 2018

There are a lot of Access is denied. messages at the end of the build. Any idea what that is about?

@mbargull
Copy link
Member Author

@msarahan: Do you have any idea what might be happening here?
I assume -- given the log is not scrambled in any way -- that part of the build log,
https://ci.appveyor.com/project/conda-forge/conda-feedstock/build/1.0.133/job/y2f8pigca3wwvqb4#L1303
to
https://ci.appveyor.com/project/conda-forge/conda-feedstock/build/1.0.133/job/y2f8pigca3wwvqb4#L1736,
corresponds to
https://github.com/conda/conda-build/blob/3.10.4/conda_build/build.py#L2022-L2032.
Hence those Access denieds should come from
https://github.com/conda/conda-build/blob/3.10.4/conda_build/build.py#L2031.

@mbargull
Copy link
Member Author

There is a similar Access denied that is the reason for gh-49: https://ci.appveyor.com/project/conda-forge/conda-feedstock/build/1.0.130/job/9wf7g6m38thf4o2e#L1740:

upload_or_check_non_existence .\recipe conda-forge --channel=main -m .ci_support\%CONFIG%.yaml
Adding in variants from internal_defaults
Adding in variants from .ci_support\win_python3.6.yaml
Attempting to finalize metadata for conda
Solving environment: ...working... done
Solving environment: ...working... done
Processing conda
Traceback (most recent call last):
  File "C:\Miniconda36-x64\Scripts\upload_or_check_non_existence.py", line 131, in <module>
    main()
  File "C:\Miniconda36-x64\Scripts\upload_or_check_non_existence.py", line 121, in main
    upload(cli, fname, owner, channel)
  File "C:\Miniconda36-x64\Scripts\upload_or_check_non_existence.py", line 68, in upload
    env=os.environ)
  File "C:\Miniconda36-x64\lib\contextlib.py", line 88, in __exit__
    next(self.gen)
  File "C:\Miniconda36-x64\Scripts\upload_or_check_non_existence.py", line 27, in get_temp_token
    shutil.rmtree(dn)
  File "C:\Miniconda36-x64\lib\shutil.py", line 494, in rmtree
    return _rmtree_unsafe(path, onerror)
  File "C:\Miniconda36-x64\lib\shutil.py", line 389, in _rmtree_unsafe
    onerror(os.unlink, fullname, sys.exc_info())
  File "C:\Miniconda36-x64\lib\shutil.py", line 387, in _rmtree_unsafe
    os.unlink(fullname)
PermissionError: [WinError 5] Access is denied: 'C:\\Users\\appveyor\\AppData\\Local\\Temp\\1\\tmp7dsv8puk\\binstar.token'

Note that this one happens in upload_or_check_non_existence.py and not in conda-build.

@mbargull mbargull mentioned this pull request May 21, 2018
Closed
@kenodegard
Copy link
Contributor

moot with #209

@kenodegard kenodegard closed this May 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mbargull @conda-forge-linter @scopatz @kenodegard